Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] The batch_size parameter has been deprecated and should be replaced by chunk_size. #49540

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Aug 7, 2024

Why I'm doing:

The batch_size parameter has been deprecated and should be replaced by chunk_size.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 7, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@EsoragotoSpirit EsoragotoSpirit merged commit 21a67ed into StarRocks:main Aug 8, 2024
43 checks passed
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.1

Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.0

Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Aug 8, 2024
Copy link
Contributor

mergify bot commented Aug 8, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)

# Conflicts:
#	docs/en/reference/System_variable.md
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)

# Conflicts:
#	docs/en/reference/System_variable.md
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (backport #49540) (#49567)

Signed-off-by: 絵空事スピリット <[email protected]>
Co-authored-by: zhanghe <[email protected]>
Co-authored-by: 絵空事スピリット <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
…aced by chunk_size. (backport #49540) (#49568)

Signed-off-by: 絵空事スピリット <[email protected]>
Co-authored-by: zhanghe <[email protected]>
Co-authored-by: 絵空事スピリット <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants