Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] The batch_size parameter has been deprecated and should be replaced by chunk_size. (backport #49540) #49567

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 8, 2024

Why I'm doing:

The batch_size parameter has been deprecated and should be replaced by chunk_size.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate

This is an automatic backport of pull request #49540 done by [Mergify](https://mergify.com). ## Why I'm doing: The batch_size parameter has been deprecated and should be replaced by chunk_size. ## What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…aced by chunk_size. (#49540)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 21a67ed)

# Conflicts:
#	docs/en/reference/System_variable.md
Copy link
Contributor Author

mergify bot commented Aug 8, 2024

Cherry-pick of 21a67ed has failed:

On branch mergify/bp/branch-3.0/pr-49540
Your branch is up to date with 'origin/branch-3.0'.

You are currently cherry-picking commit 21a67ed57d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/zh/reference/System_variable.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/en/reference/System_variable.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 8, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation automerge labels Aug 8, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 8, 2024 06:59
@mergify mergify bot closed this Aug 8, 2024
auto-merge was automatically disabled August 8, 2024 06:59

Pull request was closed

Copy link
Contributor Author

mergify bot commented Aug 8, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.0/pr-49540 branch August 8, 2024 07:00
@EsoragotoSpirit EsoragotoSpirit restored the mergify/bp/branch-3.0/pr-49540 branch August 8, 2024 07:00
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 8, 2024 07:01
Signed-off-by: 絵空事スピリット <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 586637b into branch-3.0 Aug 8, 2024
29 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.0/pr-49540 branch August 8, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge conflicts documentation Improvements or additions to documentation version:3.0.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants