Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix mysql external table clause (backport #50901) #51169

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Why I'm doing:

To avoid this mysql stament

SELECT id_tinyint, id_smallint, id_int, id_bigint, id_float, id_double, id_decimal, id_date, id_datetime, id_char, id_varchar FROM mysql_external_default WHERE (id_varchar IS NOT NULL) AND (

It happens only when runtime filter is involved:

  • there is runtime filter on mysal scan node
  • but there is no value in runtime filter
  • we don't handle that properly and add "AND(" to sql stmt

What I'm doing:

Fixes #50900

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50901 done by [Mergify](https://mergify.com). ## Why I'm doing:

To avoid this mysql stament

SELECT id_tinyint, id_smallint, id_int, id_bigint, id_float, id_double, id_decimal, id_date, id_datetime, id_char, id_varchar FROM mysql_external_default WHERE (id_varchar IS NOT NULL) AND (

It happens only when runtime filter is involved:

  • there is runtime filter on mysal scan node
  • but there is no value in runtime filter
  • we don't handle that properly and add "AND(" to sql stmt

What I'm doing:

Fixes #50900

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit 9401984 into branch-3.1 Sep 19, 2024
38 of 39 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-50901 branch September 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants