Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix mysql external table clause #50901

Merged
merged 3 commits into from
Sep 19, 2024
Merged

[BugFix] fix mysql external table clause #50901

merged 3 commits into from
Sep 19, 2024

Conversation

dirtysalt
Copy link
Contributor

@dirtysalt dirtysalt commented Sep 10, 2024 •
edited
Loading

Why I'm doing:

To avoid this mysql stament

SELECT id_tinyint, id_smallint, id_int, id_bigint, id_float, id_double, id_decimal, id_date, id_datetime, id_char, id_varchar FROM mysql_external_default WHERE (id_varchar IS NOT NULL) AND (

It happens only when runtime filter is involved:

  • there is runtime filter on mysal scan node
  • but there is no value in runtime filter
  • we don't handle that properly and add "AND(" to sql stmt

What I'm doing:

Fixes #50900

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dirtysalt dirtysalt requested a review from a team as a code owner September 10, 2024 04:04
@dirtysalt dirtysalt mentioned this pull request Sep 11, 2024
Closed
24 tasks
@dirtysalt dirtysalt force-pushed the fix-mysql-clause branch 2 times, most recently from 026482b to 9400d28 Compare September 19, 2024 00:33
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 21 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/mysql_scanner.cpp 0 21 00.00% [167, 169, 170, 171, 172, 173, 176, 178, 179, 181, 182, 183, 186, 190, 191, 192, 193, 195, 197, 198, 199]

@dirtysalt dirtysalt enabled auto-merge (squash) September 19, 2024 11:17
@dirtysalt dirtysalt merged commit 9dbe691 into StarRocks:main Sep 19, 2024
45 of 46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 19, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.2 label Sep 19, 2024
@github-actions github-actions bot removed the 3.1 label Sep 19, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt @mergify
[BugFix] fix mysql external table clause (#50901)
1cd5dc2 
(cherry picked from commit 9dbe691)
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt @mergify
[BugFix] fix mysql external table clause (#50901)
0771902 
(cherry picked from commit 9dbe691)
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt @mergify
[BugFix] fix mysql external table clause (#50901)
d11e695 
(cherry picked from commit 9dbe691)
This was referenced Sep 19, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt @mergify
[BugFix] fix mysql external table clause (#50901)
6bbf534 
(cherry picked from commit 9dbe691)
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt @mergify
[BugFix] fix mysql external table clause (#50901)
94f51b3 
(cherry picked from commit 9dbe691)
@mergify mergify bot mentioned this pull request Sep 19, 2024
Closed
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
@mergify @dirtysalt
[BugFix] fix mysql external table clause (backport #50901) (#51168)
f03619b 
Co-authored-by: RyanZ <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
@mergify @dirtysalt
[BugFix] fix mysql external table clause (backport #50901) (#51169)
9401984 
Co-authored-by: RyanZ <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
@mergify @dirtysalt
[BugFix] fix mysql external table clause (backport #50901) (#51167)
480608d 
Co-authored-by: RyanZ <[email protected]>
@dirtysalt dirtysalt deleted the fix-mysql-clause branch September 19, 2024 12:03
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
@mergify @dirtysalt @andyziye
[BugFix] fix mysql external table clause (backport #50901) (#51170)
de661db 
Co-authored-by: RyanZ <[email protected]>
Co-authored-by: AndyZiYe <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@dirtysalt @renzhimin7
[BugFix] fix mysql external table clause (StarRocks#50901)
0ac1200 
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@zombee0 zombee0 zombee0 approved these changes

@Smith-Cruise Smith-Cruise Smith-Cruise approved these changes

@Youngwb Youngwb Youngwb approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@dirtysalt dirtysalt

Labels
3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query external mysql table failed because wrong sql statement
6 participants
@dirtysalt @Seaven @Youngwb @Smith-Cruise @zombee0 @stephen-shelby