Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix mysql external table clause (backport #50901) #51171

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Why I'm doing:

To avoid this mysql stament

SELECT id_tinyint, id_smallint, id_int, id_bigint, id_float, id_double, id_decimal, id_date, id_datetime, id_char, id_varchar FROM mysql_external_default WHERE (id_varchar IS NOT NULL) AND (

It happens only when runtime filter is involved:

  • there is runtime filter on mysal scan node
  • but there is no value in runtime filter
  • we don't handle that properly and add "AND(" to sql stmt

What I'm doing:

Fixes #50900

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50901 done by [Mergify](https://mergify.com). ## Why I'm doing:

To avoid this mysql stament

SELECT id_tinyint, id_smallint, id_int, id_bigint, id_float, id_double, id_decimal, id_date, id_datetime, id_char, id_varchar FROM mysql_external_default WHERE (id_varchar IS NOT NULL) AND (

It happens only when runtime filter is involved:

  • there is runtime filter on mysal scan node
  • but there is no value in runtime filter
  • we don't handle that properly and add "AND(" to sql stmt

What I'm doing:

Fixes #50900

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@dirtysalt
Copy link
Contributor

I close this backport because I find be-ut keeps crashing here.

2024-09-19T12:12:40.1501949Z *** Aborted at 1726747955 (unix time) try "date -d @1726747955" if you are using GNU date ***
2024-09-19T12:12:40.1502472Z PC: @     0x7f01f8626a7c pthread_kill
2024-09-19T12:12:40.1502986Z *** SIGABRT (@0x1b32) received by PID 6962 (TID 0x7f01f9e2e000) from PID 6962; stack trace: ***
2024-09-19T12:12:40.1503674Z     @         0x1256f68a google::(anonymous namespace)::FailureSignalHandler()
2024-09-19T12:12:40.1504103Z     @     0x7f01f85d2520 (unknown)
2024-09-19T12:12:40.1504405Z     @     0x7f01f8626a7c pthread_kill
2024-09-19T12:12:40.1504695Z     @     0x7f01f85d2476 raise
2024-09-19T12:12:40.1504973Z     @     0x7f01f85b87f3 abort
2024-09-19T12:12:40.1505361Z     @         0x14b6e143 _ZN9__gnu_cxx27__verbose_terminate_handlerEv.cold
2024-09-19T12:12:40.1505849Z     @         0x14b6c75c __cxxabiv1::__terminate()
2024-09-19T12:12:40.1506205Z     @         0x14b6c7c7 std::terminate()
2024-09-19T12:12:40.1506517Z     @         0x14b6c97d __cxa_rethrow
2024-09-19T12:12:40.1506851Z     @         0x149647e7 std::_Hashtable<>::_M_assign<>()
2024-09-19T12:12:40.1507253Z     @         0x14961b91 std::_Hashtable<>::_Hashtable()
2024-09-19T12:12:40.1507676Z     @         0x14960263 std::unordered_map<>::unordered_map()
2024-09-19T12:12:40.1508328Z     @         0x149602a5 folly::LogHandlerConfig::LogHandlerConfig()
2024-09-19T12:12:40.1508746Z     @         0x14960339 std::pair<>::pair<>()
2024-09-19T12:12:40.1509127Z     @         0x1495c3af folly::initializeLoggerDB()
2024-09-19T12:12:40.1509573Z     @         0x1498e8a9 folly::LoggerDB::get()::Singleton::Singleton()
2024-09-19T12:12:40.1510001Z     @         0x1498efe7 folly::detail::thunk::make<>()
2024-09-19T12:12:40.1510594Z     @         0x148d0463 folly::detail::(anonymous namespace)::StaticSingletonManagerWithRttiImpl::Entry::get()
2024-09-19T12:12:40.1511392Z     @         0x148d0890 folly::detail::(anonymous namespace)::StaticSingletonManagerWithRttiImpl::create<>()
2024-09-19T12:12:40.1512088Z     @         0x148d1c42 folly::detail::StaticSingletonManagerWithRtti::create_<>()
2024-09-19T12:12:40.1512609Z     @         0x1498e7fa folly::XlogLevelInfo<>::loadLevelFull()
2024-09-19T12:12:40.1513035Z     @         0x14642052 folly::XlogLevelInfo<>::check()
2024-09-19T12:12:40.1513555Z     @         0x146c73bb _ZZN8facebook8cachelib4util5alignEmmRPvRmENKUlvE_clEv
2024-09-19T12:12:40.1514047Z     @         0x146c746a facebook::cachelib::util::align()
2024-09-19T12:12:40.1514513Z     @         0x146c77d7 facebook::cachelib::util::mmapAlignedZeroedMemory()
2024-09-19T12:12:40.1515039Z     @         0x14756540 facebook::cachelib::SlabAllocator::SlabAllocator()
2024-09-19T12:12:40.1515566Z     @         0x14714f8d facebook::cachelib::MemoryAllocator::MemoryAllocator()
2024-09-19T12:12:40.1516063Z     @         0x144c8852 std::make_unique<>()
2024-09-19T12:12:40.1516501Z     @         0x14411769 facebook::cachelib::CacheAllocator<>::initAllocator()
2024-09-19T12:12:40.1517033Z     @         0x143fb9a3 facebook::cachelib::CacheAllocator<>::CacheAllocator()
2024-09-19T12:12:40.1517564Z     @         0x143ef770 facebook::cachelib::CacheAllocator<>::CacheAllocator()
2024-09-19T12:12:40.1518116Z     @         0x11e102e4 std::make_unique<>()
2024-09-19T12:12:40.1519218Z ./run-be-ut.sh: line 257:  6962 Aborted                 ${GTEST_PARALLEL} ${STARROCKS_TEST_BINARY_DIR}/starrocks_test --gtest_catch_exceptions=0 --gtest_filter=${TEST_NAME} --serialize_test_cases ${GTEST_PARALLEL_OPTIONS}

@dirtysalt dirtysalt closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 12:56

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-50901 branch September 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant