Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix pk concurrent apply issue #51225

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[BugFix] fix pk concurrent apply issue #51225

merged 1 commit into from
Sep 23, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Sep 20, 2024 •
edited
Loading

Why I'm doing:

If we drop tablet with flag kKeepMetaAndFiles, we will remove this tablet from memory directly. However, if the tablet is the primary key table, there might still be ongoing apply tasks. We should stop the background apply tasks before deleting it; otherwise, if a new tablet is created, there could be a scenario where apply tasks are executed simultaneously.
e.g.

  1. drop and clone a new tablet with the same tablet_id.
  2. compact rocksdb meta and reload tablet again.

What I'm doing:

Stop running apply task first before remove the tablet from memory.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sevev sevev requested a review from a team as a code owner September 20, 2024 09:11
@mergify mergify bot assigned sevev Sep 20, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_manager.cpp 4 4 100.00% []

@decster decster merged commit 9dba8da into StarRocks:main Sep 23, 2024
44 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@sevev @mergify
[BugFix] fix pk concurrent apply issue (#51225)
d1c9bb8 
Signed-off-by: sevev <[email protected]>
(cherry picked from commit 9dba8da)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@sevev @mergify
[BugFix] fix pk concurrent apply issue (#51225)
ce8afba 
Signed-off-by: sevev <[email protected]>
(cherry picked from commit 9dba8da)

# Conflicts:
#	be/src/storage/base_tablet.h
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@sevev @mergify
[BugFix] fix pk concurrent apply issue (#51225)
e550dc1 
Signed-off-by: sevev <[email protected]>
(cherry picked from commit 9dba8da)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024
@mergify @sevev
[BugFix] fix pk concurrent apply issue (backport #51225) (#51286)
97e8473 
Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024
@mergify @sevev
[BugFix] fix pk concurrent apply issue (backport #51225) (#51288)
ece028d 
Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024
@mergify @sevev
[BugFix] fix pk concurrent apply issue (backport #51225) (#51287)
d440901 
Signed-off-by: sevev <[email protected]>
Co-authored-by: zhangqiang <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@sevev @renzhimin7
[BugFix] fix pk concurrent apply issue (StarRocks#51225)
c6f6390 
Signed-off-by: sevev <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb approved these changes

@decster decster decster approved these changes

Assignees

@sevev sevev

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevev @decster @wyb