[BugFix] fix pk concurrent apply issue (backport #51225) #51287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If we drop tablet with flag
kKeepMetaAndFiles
, we will remove this tablet from memory directly. However, if the tablet is the primary key table, there might still be ongoing apply tasks. We should stop the background apply tasks before deleting it; otherwise, if a new tablet is created, there could be a scenario where apply tasks are executed simultaneously.e.g.
What I'm doing:
Stop running apply task first before remove the tablet from memory.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #51225 done by [Mergify](https://mergify.com). ## Why I'm doing: If we drop tablet with flag `kKeepMetaAndFiles`, we will remove this tablet from memory directly. However, if the tablet is the primary key table, there might still be ongoing apply tasks. We should stop the background apply tasks before deleting it; otherwise, if a new tablet is created, there could be a scenario where apply tasks are executed simultaneously. e.g. 1. drop and clone a new tablet with the same tablet_id. 2. compact rocksdb meta and reload tablet again.
What I'm doing:
Stop running apply task first before remove the tablet from memory.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: