-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mavros Update to Official ROS2 Port #128
base: dev
Are you sure you want to change the base?
Conversation
Running into issues with @rob-clarke perhaps a workaround is to directly use |
@rob-clarke Is this ready to review and merge? |
Not quite. It's a start. I think there are still some config bits that don't work properly, especially if multiple drones are involved. It also has some of the test stuff in there from #134 which I'd like to merge before this |
I believe this is now ready to merge in finally :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main comments are docs need more updating. Also the install_geographiclib_datasets.sh
script should be installed with mavros, so shouldn't need to download separately
This PR closes #59 by updating mavros to use the official ros2 port (https://github.com/mavlink/mavros/tree/ros2/mavros)
All settings and use should remain the same.
It removes the use of ROS1 mavros through the Ros1 parameter bridge and all of the difficulties due to this.