-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] doodba-copier-template: domains_prod and domains_test #475
base: main
Are you sure you want to change the base?
Conversation
placeholder: | | ||
- hosts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the need of this, as there's already the same 3 lines below. Maybe we should add cert_resolver: letsencypt
by default. cc @josep-tecnativa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed duplicate lines.
The placeholder has the comment in the end, to show first the syntax of the value.
Inside a directory named 'inverseproxy', the 'shared' network will be named 'inverseproxy_shared'.
The @pedrobaeza @josep-tecnativa Is there anything you would like me to change in this PR? |
fbc8235
to
f6012fb
Compare
This was a change I made due to problems with "None" values. But if with "null" everything works correctly, please change the rest of the defaults to null... it would be the closest step to how it was before my changes: https://github.com/Tecnativa/doodba-copier-template/blame/9e48836230b19afc25103776f86077b3c5037b40/copier.yml ** And yes, I made a mistake in considering those questions as dictionaries and not as a list of dictionaries. |
Answering the copier questions, I was misleaded by the
domain_prod
anddomain_test
default value{}
when a custom value should be a list.I suggest default value
null
. When the user deletes the default value, a simple placeholder will show up.