Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] doodba-copier-template: domains_prod and domains_test #475

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions copier.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,12 @@ gitlab_url:
domains_prod:
type: yaml
multiline: true
default: {}
default: null
placeholder: |
- hosts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need of this, as there's already the same 3 lines below. Maybe we should add cert_resolver: letsencypt by default. cc @josep-tecnativa

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed duplicate lines.
The placeholder has the comment in the end, to show first the syntax of the value.

- www.main.com
- shop.main.com
examples: |
# Main domains, with TLS and cert resolved with "letsencrypt" resolver
- hosts:
- www.main.com
Expand Down Expand Up @@ -270,8 +274,12 @@ domains_prod:
domains_test:
type: yaml
multiline: true
default: {}
default: null
placeholder: |
- hosts:
- demo1.main.com
- demo2.main.com
examples: |
# Main domains, with TLS and cert resolved with "letsencrypt" resolver
- hosts:
- demo1.main.com
Expand Down