ANDROID-15197 fix headlineVisible #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
haynlo
reviewed
Sep 18, 2024
library/src/main/java/com/telefonica/mistica/list/ListRowView.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Fernando García Lidón <[email protected]>
haynlo
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks! 🙏🏼
I've just added a comment about my suggestion above: #385 (comment)
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
nimeacuerdo
reviewed
Sep 18, 2024
| [](https://search.maven.org/artifact/com.telefonica/mistica) | ||
| [](https://central.sonatype.com/artifact/com.telefonica/mistica?smo=true) |
There was a problem hiding this comment.
what about this @jeprubio ?
There was a problem hiding this comment.
Lint checker was failing all the time with https://github.com/Telefonica/mistica-android/actions/runs/10923943308/job/30322239259
- [403] https://search.maven.org/artifact/com.telefonica/mistica | Failed: Network error: Forbidden
If you use that url ( https://search.maven.org/artifact/com.telefonica/mistica ) in a browser it redirects to https://central.sonatype.com/artifact/com.telefonica/mistica?smo=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Date is not displayed on inbox notifications.
🚧 How do we do it?
Finding the bug:
The bug was introduced in this PR: https://github.com/Telefonica/mistica-android/pull/376/files#diff-a8f6455fce309bed5bb59e144ed9405f3ee9d2318b63e9a083b16a326cd8ac0c
headlineVisible was assigned with a default value according to currentHeadlineLayoutRes != HEADLINE_NONE but currentHeadlineLayoutRes was assigned after that.
Reordering the headlineVisible check after setHeadlineLayout() is done and currentHeadlineLayoutRes is set.
☑️ Checks
🧪 How can I test this?