Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-15197 fix headlineVisible #385

Merged
merged 6 commits into from
Sep 18, 2024
Merged

ANDROID-15197 fix headlineVisible #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d88a4e
ANDROID-15197 fix headlineVisible
jeprubio Sep 18, 2024
6547788
Merge branch 'refs/heads/main' into bugfix/ANDROID-15197-headlineVisi…
jeprubio Sep 18, 2024
aafd3bc
ANDROID-15197 update README link as it was giving 403 Forbidden
jeprubio Sep 18, 2024
d389f24
Apply suggestion
jeprubio Sep 18, 2024
e5e5115
ANDROID-15197 fix error in the patch
jeprubio Sep 18, 2024
c98df9d
ANDROID-15197 fix comment
jeprubio Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
![Mistica for Android](doc/images/mistica-android-dark.svg#gh-dark-mode-only)

[![Platform](https://img.shields.io/badge/Platform-Android-brightgreen)](https://github.com/Telefonica/mistica-android)
[![Version](https://maven-badges.herokuapp.com/maven-central/com.telefonica/mistica/badge.png)](https://search.maven.org/artifact/com.telefonica/mistica)
[![Version](https://maven-badges.herokuapp.com/maven-central/com.telefonica/mistica/badge.png)](https://central.sonatype.com/artifact/com.telefonica/mistica?smo=true)
Copy link
Contributor

@nimeacuerdo nimeacuerdo Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this @jeprubio ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint checker was failing all the time with https://github.com/Telefonica/mistica-android/actions/runs/10923943308/job/30322239259

If you use that url ( https://search.maven.org/artifact/com.telefonica/mistica ) in a browser it redirects to https://central.sonatype.com/artifact/com.telefonica/mistica?smo=true

[![Support](https://img.shields.io/badge/Support-%3E%3D%20Android%205.0-brightgreen)](https://github.com/Telefonica/mistica-android)
[![Kotlin version badge](https://img.shields.io/badge/kotlin-1.8.20-blue.svg)](https://kotlinlang.org/docs/whatsnew1820.html)

Expand Down
16 changes: 9 additions & 7 deletions library/src/main/java/com/telefonica/mistica/list/ListRowView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,15 +238,17 @@ open class ListRowView @JvmOverloads constructor(
R.styleable.ListRowView_listRowHeadlineLayout,
TypedValue.TYPE_NULL
)
val headlineVisible: Boolean = styledAttrs.getBoolean(
R.styleable.ListRowView_listRowHeadlineVisible,
currentHeadlineLayoutRes != HEADLINE_NONE
)
setHeadlineLayout(
setHeadlineLayout(
layoutRes = headlineResId.takeIf { it != TypedValue.TYPE_NULL } ?: HEADLINE_NONE,
contentDescription = styledAttrs.getString(R.styleable.ListRowView_listRowHeadlineContentDescription)
)
setHeadlineVisible(headlineVisible)
).also {
// Visibility decision depends on the headline layout initialization
val headlineVisible: Boolean = styledAttrs.getBoolean(
R.styleable.ListRowView_listRowHeadlineVisible,
currentHeadlineLayoutRes != HEADLINE_NONE
)
setHeadlineVisible(headlineVisible)
}

// Subtitle
setSubtitleMaxLines(styledAttrs.getInteger(R.styleable.ListRowView_listRowSubtitleMaxLines, -1))
Expand Down
Loading