IOS-10444 Mistica tokens generator #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
force-pushed
the
mistica-importer
branch
3 times, most recently
from
80b37cb to
7e32160
Compare
amegias
force-pushed
the
mistica-importer
branch
from
520623d to
652c704
Compare
This reverts commit 5d236ea.
amegias
commented
Jul 23, 2024
| @@ -17,15 +12,16 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - name: Generate Skin | |||
| run: make skin ref=${{github.event.inputs.ref}} | |||
| run: make skin | |||
There was a problem hiding this comment.
still pending, I want to modify this to have:
- one action to generate tokens in a linux machine (we don't need a macslave here)
- one action to execute tests when something changes in /scripts/mistica-tokens-generator
amegias
commented
Jul 23, 2024
|
|
||
| import UIKit | ||
|
|
||
| public extension BrandStyle { |
There was a problem hiding this comment.
moved to a different file since it shouldn't be auto-generated
|
@atabel could you give me feedback about js stuff please? :) |
amegias
commented
Jul 23, 2024
| @@ -113,7 +113,7 @@ In order to automatise this, we can execute this [GitHub action](.github/.workfl | |||
| You can also execute it manually using the actions defined in the [Makefile](Makefile). | |||
| Example: | |||
| ```bash | |||
| make skin ref=production | |||
| make skin | |||
There was a problem hiding this comment.
it will always get the production branch.
I've added doc to change this but I think it was not useful in the past...
| import { reduceColors } from "../reduce-colors"; | ||
| import { generateBrandColors } from "../brand-colors-generator"; | ||
|
|
||
| describe("generateBrandColors", () => { |
There was a problem hiding this comment.
each test file is in charge of one generator.
I pass a real input and compare with an expected content
alejandroruizponce
approved these changes
Jul 26, 2024
atabel
approved these changes
Jul 29, 2024
scripts/mistica-skin-generator/generators/colors/__tests__/brand-colors-generator.test.js
Outdated
Show resolved
Hide resolved
scripts/mistica-skin-generator/generators/colors/reduce-colors.js
Outdated
Show resolved
Hide resolved
scripts/mistica-skin-generator/generators/colors/reduce-colors.js
Outdated
Show resolved
Hide resolved
scripts/mistica-skin-generator/generators/colors/reduce-colors.js
Outdated
Show resolved
Hide resolved
scripts/mistica-skin-generator/generators/colors/reduce-colors.js
Outdated
Show resolved
Hide resolved
scripts/mistica-skin-generator/generators/colors/__tests__/brand-colors-generator.test.js
Outdated
Show resolved
Hide resolved
* Tests action for the tool * Create a new workflow for mistica-skin-generator-tests and modify the generation flow to generate tokens * Test show URL * Clean up
|
🎉 This PR is included in version 31.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10444
🥅 What's the goal?
Fix the mistica tokens generator which is broken due to the gradient colors.
🚧 How do we do it?
I've created a sub-folder in the project and develop a new tool in js to get the files and add the logic to resolve the Mistica colors problem. The previous tool was very simple and I need to add logic to decide if a color is gradient, solid,... depending on the rest of the brands.
I've added doc to this folder
I've added tests to this tool. I will execute it from GH actions.
I will automatise it from GH actions since it can be executed in a linux runner (IOS-10444 Mistica importer from GH Actions #390).
🧪 How can I verify this?
Part I
I've generated & pushed the new generated files. The tests passed.
I've restored because I don't want to add noise to this PR.
Part II
make skin