IOS-10444 Mistica importer from GH Actions #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generation flow to generate tokens
amegias
force-pushed
the
mistica-importer-ghaction
branch
from
b7f666f to
2c1e100
Compare
amegias
force-pushed
the
mistica-importer-ghaction
branch
from
b3dc354 to
a545cf2
Compare
amegias
changed the title
amegias
commented
Jul 23, 2024
| runs-on: self-hosted-novum-mac | ||
| build: | ||
| name: Build & generate tokens | ||
| runs-on: ubuntu-latest |
amegias
commented
Jul 23, 2024
Comment on lines
+5
to
+7
| push: | ||
| paths: | ||
| - 'scripts/mistica-skin-generator/**' |
There was a problem hiding this comment.
only when the generator changes
alejandroruizponce
approved these changes
Jul 26, 2024
atabel
approved these changes
Jul 30, 2024
amegias
added a commit
that referenced
this pull request
Jul 31, 2024
…387) * Tool * Test tokens generation * Revert "Test tokens generation" This reverts commit 5d236ea. * CR improvements * Use snapshots * Add JSDoc * setup eslint * configure prettier * Run Prettier * Fix lint * IOS-10444 Mistica importer from GH Actions (#390) * Tests action for the tool * Create a new workflow for mistica-skin-generator-tests and modify the generation flow to generate tokens * Test show URL * Clean up --------- Co-authored-by: Abel Toledano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10444
🥅 What's the goal?
Having the generation fixed here #387, we need to integrate it in GitHub Actions.
🚧 How do we do it?
Now it's simpler since it's just a node execution, see the code.
I've added the tests execution too.
🧪 How can I verify this?
Tests
I've forced it manually:
Generation
I've forced it manually: