Improve context storage to share data through whole run

[legnadev]

Improved the managing of storages:

• Added run_storage to store information during the whole test execution
• Storages chained to be able to get the information always from context.storage / [CONTEXT:]
• In steps, be able to store values into desire storage by using [key], [FEATURE:key] and [RUN:key]. Example:
  • I store in key "store_key" the value "XXX"
  • I store in key "[FEATURE:store_key]" the value "XXX"
  • I store in key "[RUN:store_key]" the value "XXX"
• Implemented new method store_key_in_storageto manage it

[pabloge]

Please provide motivation and detailed description.

[josemiguel-rodrigueznaranjo]

LGTM

[legnadev]

Redesigned again with Chainmap, this time making sure it works, just to give more information:
ChainMap unifies, or links, the 3 context dictionaries into one

Considering we have a mapchain( Dict1, Dict2, Dict3) where dicts are storage, feature and run:

• If i get a value with context.storage["key"] the first key found in the 3 dictionaries will be retrieved, accesing them by order from left to right. So if we have a duplicated key in storate and run storage, it will get the storage one. -> To avoid this, the programmer should be responsible of where the key is added, but we handle it if you use the store_in_context function.
• If i set a value into context.storage, it will be stored in the first dictionary always, so it will always be stored in context.storage so this leaves the context.storage to work as the previous behavior as desired and expected.
• context.storage and run_storage are linked in before all, so instead of a chainmap, any change you do to storage is stored in run, which is an expected behaviour since the only existant context in before all is the run_storage.

[josemiguel-rodrigueznaranjo]

LGTM

[pabloge]

The new logic based on ChainMaps to search for storage keys is OK.

The new function to store values in one place or another depending on their prefix does not seem like a good programming practice to me, especially in the context of BDD, and I would remove it.

[codeclimate]

Code Climate has analyzed commit 8c9c7b1 and detected 0 issues on this pull request.

View more on Code Climate.