-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve context storage to share data through whole run #396
Merged
legnadev
merged 29 commits into
Telefonica:master
from
josemiguel-rodrigueznaranjo:feat/improve_storage
Sep 10, 2024
Merged
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8671248
Improve storage in context
josemiguel-rodrigueznaranjo aaf21ec
Fix in changelog
josemiguel-rodrigueznaranjo 2c126b6
add run storage
legnadev 4f93209
Fix in changelog
josemiguel-rodrigueznaranjo f3b8268
Update CHANGELOG.rst
josemiguel-rodrigueznaranjo 87eefd3
Merge branch 'feat/improve_storage' of github.com:josemiguel-rodrigue…
josemiguel-rodrigueznaranjo 0d7db1d
fix linter
legnadev 87791bd
fix linter
legnadev 8935bc3
Improve _get_initial_value_from_context
josemiguel-rodrigueznaranjo 13e0e14
Merge branch 'feat/improve_storage' of github.com:josemiguel-rodrigue…
josemiguel-rodrigueznaranjo 555822f
Improve _get_initial_value_from_context
josemiguel-rodrigueznaranjo 8f528fd
Rename store_key_in_storage
josemiguel-rodrigueznaranjo ca23ff6
Improve store_key_in_storage
josemiguel-rodrigueznaranjo 6ed93a7
Added test to check storage capabilities
josemiguel-rodrigueznaranjo dcfc351
Fix in test
josemiguel-rodrigueznaranjo 90d4fe5
Added test to check storage capabilities
josemiguel-rodrigueznaranjo a5385a0
Added test to check storage capabilities
josemiguel-rodrigueznaranjo f407411
Added test to check storage capabilities
josemiguel-rodrigueznaranjo 289c4a5
Improved managing of storages using ChainMap
josemiguel-rodrigueznaranjo cc0e689
Update version and changelog
josemiguel-rodrigueznaranjo 01b4b7a
Merge branch 'master' into feat/improve_storage
josemiguel-rodrigueznaranjo 34f6c7f
Debugging
josemiguel-rodrigueznaranjo 93ea8a9
Improved managing of storages when dynamic env are not used
josemiguel-rodrigueznaranjo 0adb553
Fix lint warning
josemiguel-rodrigueznaranjo 6a2090e
Fix lint warning
josemiguel-rodrigueznaranjo bd6fd9e
Fix lint warning
josemiguel-rodrigueznaranjo 49d6d26
Fix lint warning
josemiguel-rodrigueznaranjo 71f8905
Updated Changelog
josemiguel-rodrigueznaranjo 8c9c7b1
Remove dict() from a ChainMap in before_feature
josemiguel-rodrigueznaranjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
3.1.6.dev0 | ||
3.1.6.dev1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redesigned again with Chainmap, this time making sure it works, just to give more information:
ChainMap unifies, or links, the 3 context dictionaries into one
Considering we have a mapchain( Dict1, Dict2, Dict3) where dicts are storage, feature and run: