Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): fix selective enabling of highlighting #3420

Conversation

TomJGooding
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3419.

According to the Highlighting docs:

If you disable highlighting on the [Console] constructor, you can still selectively enable highlighting with highlight=True on print / log.

Unfortunately it looks like this hasn't worked since Rich v9.5.0! I am assuming this is a bug rather than an intentional change, but if that's the case then the documentation should be updated.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (9b4e3f1) to head (1174c72).
Report is 21 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3420      +/-   ##
==========================================
+ Coverage   95.18%   98.23%   +3.05%     
==========================================
  Files          74       74              
  Lines        8059     8060       +1     
==========================================
+ Hits         7671     7918     +247     
+ Misses        388      142     -246     
Flag Coverage Δ
unittests 98.23% <ø> (+3.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan willmcgugan merged commit 7eaaa66 into Textualize:master Aug 26, 2024
21 checks passed
@TomJGooding TomJGooding deleted the fix-console-fix-selective-enabling-of-highlighting branch August 27, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants