CTS-Avoid level balance buffers overlap. #5819
Draft
+67
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
secure ci? |
maliberty
requested changes
Oct 4, 2024
src/cts/src/LevelBalancer.cpp
Outdated
| / wireSegmentUnit_; | ||
| Point<double> bufferLoc(x, y); | ||
| if (level % buffPerStep) { | ||
| x = (x + width); |
There was a problem hiding this comment.
x += width; is more idiomatic. (likewise y)
src/cts/src/LevelBalancer.cpp
Outdated
Comment on lines
102
to
107
| int dir = (centroidY - y) / std::abs(centroidY - y); | ||
| double height = builder->getBufferHeight() * wireSegmentUnit_ * dir; | ||
| double width = builder->getBufferWidth() * wireSegmentUnit_ * dir; | ||
|
|
||
| int steps = std::max((int) (std::abs((centroidY - y) / height)), 1); | ||
| int buffPerStep = std::ceil((float) bufLevels / (float) steps); |
src/cts/src/LevelBalancer.cpp
Outdated
| int x = prevLevelSubNet->getDriver()->getX(); | ||
| int y = prevLevelSubNet->getDriver()->getY(); | ||
|
|
||
| int dir = (centroidY - y) / std::abs(centroidY - y); |
There was a problem hiding this comment.
Why use the same direction for both x & y? You might be moving away from the centroid in x.
There was a problem hiding this comment.
Yes, I missed that. It was already fixed, thanks.
|
Secure Ci is passing, only need to update a antenna diode count metric for 1 design. I am going to create a PR for this update. |
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Level Balancer of CTS tends to insert buffers one on top of the other and when they are legalized a cluster of buffers is formed, issue #2305 shows an example of this. This happens specially if the clock buffers are large and it creates a high congested area that can lead to the global router finishing with overflow.
This PR changes the level balancer to avoid overlapping the inserted buffers and preventing the creation of the clusters of buffers. The next images show the result for the regressions test of CTS balance_levels:
Current:
New:
