Fixed post items getting cut off on iOS #17189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17189 +/- ##
==========================================
+ Coverage 66.98% 71.76% +4.78%
==========================================
Files 1475 1836 +361
Lines 83777 116454 +32677
Branches 11332 17301 +5969
==========================================
+ Hits 56115 83575 +27460
- Misses 26531 31756 +5225
+ Partials 1131 1123 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
minimaluminium
approved these changes
Oct 4, 2023
daniellockyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!
This PR is a fixed version of #16765. I took a different approach for this to work around some of the issues that were found after that one got merged. In that PR's description, I mentioned that there were multiple scroll areas for the post editor that were somehow displaying at different sizes. The reason appears to be that the CSS
vhunit includes some areas that are obscured by Safari's toolbars, since those toolbars may disappear if the<body>element is scrolled. However, since Ghost's admin area uses<div>elements for all scrolling, those toolbars never disappear, and so the space becomes unused. We can work around this by changing to the CSSdvhunit, which always represents the current size of the viewport.Most pages have enough padding that the
vhunit doesn't cause any problems. In this PR, I've changed it for two places that do break, the post editor and the post settings menu (which can get the "Delete" button cut off). I also included the sidebar width fix from the previous PR.Video of the fixed behavior (compare with the old behavior video linked in #16765): link