Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed post items getting cut off on iOS #17189

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fixed post items getting cut off on iOS #17189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
417b710
Fix post items getting cut off on iOS.
JBYoshi Jul 3, 2023
8934abd
Merge branch 'main' into mobile/post-scrolling-2
minimaluminium Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghost/admin/app/components/gh-koenig-editor-lexical.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="gh-koenig-editor relative w-100 vh-100 overflow-x-hidden overflow-y-auto z-0" {{did-insert this.registerElement}} ...attributes>
<div class="gh-koenig-editor relative z-0" {{did-insert this.registerElement}} ...attributes>
{{!-- full height content pane --}}
{{!-- template-lint-disable no-invalid-interactive no-passed-in-event-handlers --}}
<div
Expand Down
2 changes: 1 addition & 1 deletion ghost/admin/app/components/gh-koenig-editor.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="gh-koenig-editor relative w-100 vh-100 overflow-x-hidden overflow-y-auto z-0" {{did-insert this.registerElement}} ...attributes>
<div class="gh-koenig-editor relative z-0" {{did-insert this.registerElement}} ...attributes>
{{!-- full height content pane --}}
{{!-- template-lint-disable no-invalid-interactive no-passed-in-event-handlers --}}
<div
Expand Down
8 changes: 8 additions & 0 deletions ghost/admin/app/styles/components/koenig.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,14 @@
height: 1.6rem;
}

/* Scroll container for the editor canvas */
.gh-koenig-editor {
width: 100%;
height: 100dvh;
overflow-x: hidden;
overflow-y: auto;
}

/* Padded container housing title + editor canvas, scrollable content */
.gh-koenig-editor-pane {
padding: 11vw 92px;
Expand Down
24 changes: 22 additions & 2 deletions ghost/admin/app/styles/components/settings-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

.settings-menu-container {
z-index: 999;
height: 100vh;
height: 100dvh;
min-width: 420px;
overflow-x: visible;
overflow-y: auto;
Expand All @@ -70,6 +70,19 @@
}
}

@media (max-width: 800px) {
.settings-menu-container {
padding-bottom: 64px;
}
}

@media (max-width: 500px) {
.settings-menu-container {
width: 100vw;
min-width: 100vw;
}
}

.settings-menu-container .settings-menu-pane {
position: absolute;
top: 0;
Expand All @@ -93,7 +106,14 @@
top: auto;
right: auto;
bottom: auto;
height: 100vh;
height: 100dvh;
}

@media (max-width: 500px) {
.settings-menu-container .settings-menu-pane {
width: 100vw;
min-width: 100vw;
}
}

/* Header
Expand Down
Loading