-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary pressure transducer implementation with INA219 #30
Conversation
67a3b24
to
b1102c1
Compare
Rewired the INA219 circuit and tested this code in lab earlier this week with a potentiometer. While we were able to see current readings decrease as we increased resistance and vice versa, the bus voltage reading is somehow above 5V. Perhaps this has to do with the calibration value. |
aae5209
to
02c6c1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we refactor the measurement functionality into a reusable abstraction for a pressure transducer as described in #27?
78f111d
to
0f4ae82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far: still looking for the pressure calculation, and some thoughts on the intermediate layer and demo function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the rebase/merge? Seeing changes from the other PR mixed in.
436a0be
to
c0ebeea
Compare
c04364e
to
f2921c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, please squash during merge.
This pull request adds a new module that includes a single function to read current from an INA219 sensor and spawns a new Tokio task that runs this function.
I will be testing the functionality of this code in lab with the sensor soon.