Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate temperature monitoring with FSM #64

Merged
merged 15 commits into from
May 25, 2024
Merged

Integrate temperature monitoring with FSM #64

merged 15 commits into from
May 25, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented May 22, 2024 •
edited by taesungh
Loading

tested in lab w sam.
Resolves #55.

taesungh
taesungh reviewed May 23, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, some small notes on naming and possibly restructuring our struct method.

pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Show resolved Hide resolved
@taesungh taesungh changed the title [Pod] Integrate temperature monitoring with FSM #55 Integrate temperature monitoring with FSM May 23, 2024
SM-dot
SM-dot approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@SM-dot SM-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

taesungh
taesungh approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, will revisit the two comments later.

@taesungh taesungh mentioned this pull request May 25, 2024
Closed
@samderanova
Copy link
Contributor

Looks good, please squash during merge.

@taesungh taesungh merged commit 1ad28c8 into main May 25, 2024
2 checks passed
This was referenced May 25, 2024
Closed
Closed
@taesungh taesungh deleted the therm_int branch May 29, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

@taesungh taesungh taesungh approved these changes

@SM-dot SM-dot SM-dot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pod] Integrate temperature monitoring with FSM
4 participants
@ryescholin @samderanova @taesungh @SM-dot