-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPS Drivers #4
base: main
Are you sure you want to change the base?
Conversation
I tested the ECEF polling on EVE and it didn't work, but PVT did.
Oh and could you add the ECEF conversion code, after that I think we're good to go |
without doing this, it tried putting `Init` in gps.cc on a single line, which was really dumb.
@DanielHeEGG can u look at this again? You didn't request changes last time so there's no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! some more minor suggestions, little functional change. Plz fix file namings and ensure snake case. @MichaelKrinsky plz take a look as well
Looked through everything. Daniel covered everything I found. Once done with his changes should be good. |
so we merging this or what? At this point I think any changes are just bugfixes and they make more sense as separate PRs instead of tacking onto this one. |
Add GPS drivers for u-blox m8 receiver. To test this, I'm using this main program on EVE and running it with breakpoints in the debugger to see what statements it gets to and for inspecting variables: