Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nsi processor #29
Nsi processor #29
Changes from 30 commits
917bb16
6d63b42
a0559c2
cbf06d8
2163411
e090217
d0ac729
bb16055
17c84dd
e6dced2
c5d1843
72f0d32
a09045c
0819886
a7a1415
7b91ac3
92148cd
0c4b9ad
2cc7a8f
2d466f4
b3f0687
aa7aeee
f73e7ad
9b9b553
10ae683
f11ff66
69f8171
c6dacc3
611b66e
d4584e8
c390072
6cb2f02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like leftover from testing. Should probably be removed. Any testing specific logic should be in the test classes.
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 70 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment. self evident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code.
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
Check warning on line 110 in Consequences/Consequences/NSIStreamingProcessor.cs
GitHub Actions / CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await sp.Process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be deleted so long as the test above covers our bases.