Nsi processor #29
Merged
Nsi processor #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brennan1994
reviewed
Aug 28, 2024
| } | ||
|
|
||
| public async Task TestProcessStream(BoundingBox boundingBox, Action<IConsequencesReceptor> ConsequenceReceptorProcess) |
There was a problem hiding this comment.
This looks like leftover from testing. Should probably be removed. Any testing specific logic should be in the test classes.
| { | ||
| try | ||
| { | ||
| // send HTTP GET request |
There was a problem hiding this comment.
remove comment. self evident.
|
|
||
| } | ||
| /* | ||
| [Fact] |
There was a problem hiding this comment.
This can probably be deleted so long as the test above covers our bases.
This was
linked to
issues
Aug 28, 2024
Brennan1994
requested changes
Aug 28, 2024
Brennan1994
reviewed
Aug 28, 2024
| @@ -25,4 +20,25 @@ public void Test() | |||
| consoleWriter.Write(r); | |||
Brennan1994
reviewed
Aug 28, 2024
|
|
||
| // Create an instance of HttpClient | ||
| using (HttpClient client = new HttpClient()) | ||
| using HttpClient client = new HttpClient(); |
Brennan1994
reviewed
Aug 28, 2024
| { | ||
| // access the properties of each structure | ||
| JsonElement propertiesElement = structure.GetProperty("properties"); | ||
| Structure s = JsonSerializer.Deserialize<Structure>(propertiesElement.GetRawText()); |
There was a problem hiding this comment.
Look into how to ignore this warning
Brennan1994
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.