-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Arducam Driver #287
base: main
Are you sure you want to change the base?
Conversation
…ode into seperate file
…folder; moved image_processing files to payload mgr folder; initial commit of camera_control file
…a capture; renamed ov5642_reg files to config ov5642_config files
…finish_arducam_driver
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone else got to review it as well
… initSelected camera
…finish_arducam_driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, just those few things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I remember seeing that someone else took on the task of starting to write this driver. Might introduce conflicts by merging this in. It's only other usage is commented out. Delete this folder?
for the arducamTransitOpcode function, before these changes it defaulted to a LOG_ERROR_CODE(Invalid arg). With the new format, is that still necessary? |
I don't believe that will be necessary, as all inputs to the function will be valid members of the opcode enum, which can all be directly passed. |
obc/app/drivers/arducam/arducam.h
Outdated
*/ | ||
bool isCaptureDone(camera_t cam); | ||
obc_error_code_t camWriteSensorRegs16_8(const sensor_config_t reglist[], uint16_t reglistLen); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this to match the change to size_t
Purpose
Testing and cleaning up arducam driver code.
New Changes
Testing
Initial capture:
Outstanding Changes