Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Arducam Driver #287

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Finish Arducam Driver #287

wants to merge 22 commits into from

Conversation

Gjjjiang
Copy link
Contributor

@Gjjjiang Gjjjiang commented Apr 2, 2024

Purpose

Testing and cleaning up arducam driver code.

New Changes

  • Added new test app code for arducam.
  • Move the image_processing files into a higher-level module (with all the other payload code).
  • Separated the TCA (I2C mux) functions code into a separate driver.
  • Decouple the driver from the file system.
  • Combine camera_reg and arducam files into one.
  • Reorganized Arducam Driver code.
  • Added higher level camera control functions

Testing

  • Tested with test app.
    Initial capture:
    image

Outstanding Changes

  • Research proper sensor configuration to get better image
  • Add any additional control functions when needed.

Copy link

github-actions bot commented Apr 2, 2024

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
dgobalak 25 1d 5h 24m 134
Navtajh04 18 4d 7h 34m 108
Yarik-Popov 14 6d 11h 3m 95
PratyushMakkar 5 7d 14h 7m 22
Gjjjiang 4 4d 15h 52m 14
manumanuk 2 35d 14h 41m 5
kepler452b123 2 47d 7h 49m 24
twilkhoo 1 4m 0
JoelManYunLee 1 17h 57m 4
⚡️ Pull request stats

Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else got to review it as well

obc/app/modules/camera_mgr/camera_control.h Outdated Show resolved Hide resolved
obc/app/modules/camera_mgr/camera_control.h Show resolved Hide resolved
obc/app/sys/obc_errors.h Outdated Show resolved Hide resolved
obc/app/drivers/tca9458a/tca9458a.c Show resolved Hide resolved
obc/app/modules/camera_mgr/camera_control.c Outdated Show resolved Hide resolved
obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
Copy link
Contributor

@jordynmindorff jordynmindorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just those few things

obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I remember seeing that someone else took on the task of starting to write this driver. Might introduce conflicts by merging this in. It's only other usage is commented out. Delete this folder?

obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
obc/app/drivers/arducam/arducam.c Outdated Show resolved Hide resolved
obc/app/drivers/arducam/arducam.c Show resolved Hide resolved
@tangerine238
Copy link

for the arducamTransitOpcode function, before these changes it defaulted to a LOG_ERROR_CODE(Invalid arg). With the new format, is that still necessary?

@jordynmindorff
Copy link
Contributor

for the arducamTransitOpcode function, before these changes it defaulted to a LOG_ERROR_CODE(Invalid arg). With the new format, is that still necessary?

I don't believe that will be necessary, as all inputs to the function will be valid members of the opcode enum, which can all be directly passed.

*/
bool isCaptureDone(camera_t cam);
obc_error_code_t camWriteSensorRegs16_8(const sensor_config_t reglist[], uint16_t reglistLen);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this to match the change to size_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants