-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure for homotopies between maps out of a suspension #924
Conversation
Would it make sense to have a file just for homotopies of suspension structures? Right now all code related to that subject is living in the suspensions file. But there are a fair amount of auxiliary lemmas and equivalences kinda crowding that file up. And there will likely be a few more that I need to add. |
Although I don't have the files in memory, that sounds very reasonable to me. We do a similar thing for many other concepts, and if that makes things more navigable in your opinion, then I say go ahead. |
I had hoped to add a bit more code to this pr before marking it ready, But it seems that some refactoring and creating new files is necessary to make that work. Thus I'm going to clean up this pr by removing the unsolved goals and unfinished code, and then mark it as ready. Then I will subsequently sumbit a refactoring pr followed by a pr to finish off building up the infrastructure for homotopies. I hope this last pr will include some "proof of concept" code, showing that the infrastructure works and is easy to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't taken the time to review the namings of all the definitions in this PR yet, but I'll say the quality of the PR looks excellent over all.
One remark: I noticed there is a recurring theme of misindented code where this would be easy to detect with rainbow parentheses (i.e. colorcoded parentheses). Have you looked into whether such a feature exists for your editor? I can highly recommend it. 👍
Thanks for the pointer, I should be able to get that set up in emacs! Sorry about all those formatting errors... Thank you for taking the time to look through this pr so closely |
Co-authored-by: Fredrik Bakke <[email protected]>
Re @fredrik-bakke suggestion to move the computation of inverses of
I could leave the computation of the inverse of |
This pr builds upon the infrastructure for constrcting and working with homotopies between maps out of a suspension. This includes:
north-suspension
andsouth-suspension
htyp-suspension-structure
It remains to compute the value of such a homotopy when applied to
meridian-suspension
. Additionally, it remains to construct a simplified version of the equivalence for maps of the formmap-inv-up-suspension X Y c
, for somec : suspension-structure X Y
.