-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor universal property of suspensions #961
Refactor universal property of suspensions #961
Conversation
Wouldn't it be better convert to stating universal properties in |
Backward compatibility, I suppose. |
src/synthetic-homotopy-theory/dependent-universal-property-suspensions.lagda.md
Outdated
Show resolved
Hide resolved
Also, sometimes it is used in Sigma types. E.g. universal-property-pushout-extension-by-equivalences :
{l : Level} → is-equiv i → is-equiv j → is-equiv k →
Σ (cocone f' g' X) (λ d → universal-property-pushout-Level f' g' d l) |
src/foundation/universal-property-cartesian-product-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-universal-property-suspensions.lagda.md
Show resolved
Hide resolved
Ah, your point is here. That code doesn't look very good to me. Looks like I have another refactoring job to do. |
Wait I think I am already doing that refactoring in #885. Mind you I might have been addressing some of these universal properties there too. |
Oh no. I was working on that right now |
I think #885 is already much deeper in than you are here. Since this pr is <200 lines of code, perhaps it would be better to abandon this one. I'm really sorry. |
Well, 200 LOC is what I've pushed... |
Also, there doesn't seem to be any overlap in what I've actually pushed. Am I missing something? |
I decided to just ignore the |
src/species/composition-cauchy-series-species-of-types.lagda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Vojtěch Štěpančík <[email protected]>
Co-authored-by: Vojtěch Štěpančík <[email protected]>
Refactors universal properties of suspensions to use the
Level
-naming scheme.