Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v3-sdk): separate esm / cjs builds #225

Closed
wants to merge 1 commit into from

Conversation

just-toby
Copy link
Collaborator

@just-toby just-toby commented Dec 16, 2024

PR Scope

breaking change to build structure for v3-sdk

Description

updates the build setup for v3-sdk to manually and explicitly create separate cjs and esm builds (plus a types-only version)

How Has This Been Tested?

built the sdk locally, then installed the local build result in another project (universe/apps/web) and verified that it properly resolved the esm version instead of the cjs version

Are there any breaking changes?

there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update

(Optional) Follow Ups

PRs to follow will do this for many other SDKs

@just-toby just-toby marked this pull request as ready for review December 16, 2024 20:20
@just-toby just-toby requested review from jsy1218 and a team as code owners December 16, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant