feat(v2-sdk): separate esm/cjs builds #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected] |
This was referenced Dec 16, 2024
just-toby
force-pushed
the
feat/v2-sdk-build-2
branch
from
df7fa2f to
6faef94
Compare
just-toby
changed the base branch from
feat/router-sdk-build
to
feat/v4-sdk-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
breaking change to build structure for
v2-sdkDescription
updates the build setup for
v2-sdkto manually and explicitly create separate cjs and esm builds (plus a types-only version)How Has This Been Tested?
built the sdk locally, then installed the local build result in another project (
universe/apps/web) and verified that it properly resolved the esm version instead of the cjs versionAre there any breaking changes?
there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update
(Optional) Follow Ups
PRs to follow will do this for many other SDKs