First hacky implementation of reusing the initial_positions for view_ur #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have the config file in place already, anyway, we can also use the parameters.
There are a couple of things I don't like about this implementation:
initial_positions.yaml
is not. (See possible workaround 1)LaunchConfiguration
object. But that might just be me being stupid.Possible workaround 1: Include separate file
With defining a separate file with content
we could pass that file to the node directly. However, this would be config duplication.
As I couldn't come up with a better solution, I postet a question on ROS answers: https://answers.ros.org/question/396653/ros2-python-launchfile-load-parametersyaml-into-nodes-parameter/