Skip to content

Commit

Permalink
Fix invalid version header destination (#434)
Browse files Browse the repository at this point in the history
Fixes #409 (#434)
  • Loading branch information
tom91136 authored Oct 31, 2024
1 parent 7018211 commit 1d9e277
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/lib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ add_library(libsimeng SHARED ${SIMENG_SOURCES} ${SIMENG_HEADERS})
set_target_properties(libsimeng PROPERTIES OUTPUT_NAME simeng)

target_include_directories(libsimeng PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
target_include_directories(libsimeng PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
target_include_directories(libsimeng PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
target_link_libraries(libsimeng capstone)
# Only enable compiler warnings for our code
target_compile_options(libsimeng PRIVATE ${SIMENG_COMPILE_OPTIONS})
Expand All @@ -69,5 +69,4 @@ install(TARGETS libsimeng DESTINATION lib)
get_target_property(SIMENG_COMPILE_OPTIONS libsimeng COMPILE_OPTIONS)
get_target_property(SIMENG_COMPILE_DEFINITIONS libsimeng COMPILE_DEFINITIONS)
get_target_property(SIMENG_VERSION libsimeng VERSION)
# TODO move this to build folder. Cmake may not reconfigure when rebuilding after a change, therefor version.hh and cmake options can differ. This is happens especially when using an IDEs when changing build types
configure_file(${PROJECT_SOURCE_DIR}/src/include/simeng/version.hh.in ${PROJECT_SOURCE_DIR}/src/include/simeng/version.hh)
configure_file(${PROJECT_SOURCE_DIR}/src/include/simeng/version.hh.in ${CMAKE_CURRENT_BINARY_DIR}/simeng/version.hh)

0 comments on commit 1d9e277

Please sign in to comment.