Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings #408

Merged
merged 63 commits into from
Jun 4, 2024
Merged

Warnings #408

merged 63 commits into from
Jun 4, 2024

Conversation

dANW34V3R
Copy link
Contributor

Testing CI

@dANW34V3R
Fix most warning and add comments
ec1a657
@dANW34V3R
More fixes
6593341
@dANW34V3R
Fixup tests
43e266b
@dANW34V3R
Handle output of system calls
6b1544b
@dANW34V3R
Fix warning for tests in release mode
823b7f1
@dANW34V3R
Fix commitMicroOps
b69318f
@dANW34V3R
Add default binary
998b8cf
@dANW34V3R
Fix AT_FCWD on Mac
a824732
@dANW34V3R
Quash armclang warning
0bcbf17
@dANW34V3R
Quash armclang float.hh
a3252c0
@dANW34V3R
Conditionally include filesystem.h
1773f5d
@dANW34V3R
Update jenkins comparison values
fafb331
@dANW34V3R
Add pedantic warnings and only give warnings for SimEng
8eb411d
@dANW34V3R
Fix pedantic warnings
c27d3cf
@dANW34V3R
Update default binary's path to be absolute. Needed if binary called …
8ace4dd 
…from directory without default program
@dANW34V3R
Update jenkins comparison values
c5a4372
@dANW34V3R
Update jenkins for tx2 run
83441d0
@dANW34V3R
Update unit tests
796f5bf
@dANW34V3R
Update tests to use dynamic stack pointers
c810db5
@dANW34V3R
Update command line string for OSTest
25b6ccd
@dANW34V3R
Fix cmdLine
e72941d
@dANW34V3R
Turn warnings into errors
34d9e96
@dANW34V3R
Remove extra semicolons
b01493e
@dANW34V3R
Prevent unused tuple member warning
be847ae
@dANW34V3R
Clang format
23eb995
@dANW34V3R
Pedantic warnings for all tests
ab0a3b6
@dANW34V3R
Build in release mode for CI
4c74f63
@dANW34V3R
Fix warnings in tests
9ed5edc
@dANW34V3R
TEMP add Wextra
8226395
@dANW34V3R
Change char* to uint8*
379362a
@tom91136 tom91136 mentioned this pull request May 24, 2024
Open
@tom91136
Copy link
Member

LGTM

@tom91136
Copy link
Member

The CMake issue will be a separate PR

FinnWilkinson
FinnWilkinson previously requested changes May 29, 2024
View reviewed changes
src/lib/kernel/Linux.cc Outdated Show resolved Hide resolved
sst/test/include/framework/runner.hh Outdated Show resolved Hide resolved
jj16791
jj16791 reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jj16791 jj16791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to resolve that last comment then it should be good to run through validation

JosephMoore25
JosephMoore25 requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@JosephMoore25 JosephMoore25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much everything that raised questions has already been answered and resolved. A couple more tiny changes, but overall looks like good work!

src/lib/kernel/Linux.cc Outdated Show resolved Hide resolved
src/lib/pipeline/FetchUnit.cc Outdated Show resolved Hide resolved
test/regression/aarch64/instructions/sve.cc Show resolved Hide resolved
JosephMoore25
JosephMoore25 previously approved these changes Jun 4, 2024
View reviewed changes
ABenC377
ABenC377 previously approved these changes Jun 4, 2024
View reviewed changes
jj16791
jj16791 previously approved these changes Jun 4, 2024
View reviewed changes
@dANW34V3R dANW34V3R dismissed stale reviews from jj16791, ABenC377, and JosephMoore25 via 08376f1 June 4, 2024 14:32
@jj16791 jj16791 dismissed stale reviews from FinnWilkinson and tom91136 June 4, 2024 15:31

Already have 3 approvals

@dANW34V3R dANW34V3R merged commit 3ffa987 into dev Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom91136 tom91136 tom91136 left review comments

@ABenC377 ABenC377 ABenC377 approved these changes

@JosephMoore25 JosephMoore25 JosephMoore25 approved these changes

@jj16791 jj16791 jj16791 approved these changes

@FinnWilkinson FinnWilkinson FinnWilkinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
SimEng Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dANW34V3R @tom91136 @jj16791 @FinnWilkinson @JosephMoore25 @ABenC377