Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD #437

Merged
merged 255 commits into from
Nov 6, 2024
Merged

CI/CD #437

merged 255 commits into from
Nov 6, 2024

Conversation

ABenC377
Copy link
Contributor

Upstreaming the build, test and benchmark components of Leo's CI/CD pipeline

haelai77 added 30 commits August 1, 2024 14:31
@haelai77
removing token
8948df4
@haelai77
adding git for testing checking out benchmark repo
3014dab
@haelai77
added upgrade before installing deps
9f30c91
@haelai77
adding back token
7d91421
@haelai77
testing setting secret as env varibale
c4f47a4
@haelai77
testing with admin rights
5739597
@haelai77
testing with admin rights + directly using secret
ababc8d
@haelai77
fake push to test secret
68b2111
@haelai77
fake push to test secret number 2
c5fe985
@haelai77
fake push to test secret number 3
e65bb3e
@haelai77
testing build and checking out benchmark
3558792
@haelai77
removed redundant steps for testing secrets
038b514
@haelai77
fixed checkout path
b95a648
@haelai77
fixed passing secret into action by setting it as env var
a9c50ab
@haelai77
switched to side by side checkouts
16e24d6
@haelai77
switching path to actions
25cdc4a
@haelai77
reverted path back to relative for action
e48e4fe
@haelai77
swaping path to benchmark directory
606cea7
@haelai77
attempting to run benchmarks
77b77c6
@haelai77
added pyparsing module for python benchmark script
d8a77d0
@haelai77
added pip
5d0f32f
@haelai77
enabling benchmark step for rest of os and compiler suit
41dea6e
@haelai77
fixed pip package name in script
f1c300a
@haelai77
changed pip to pip3
964796e
@haelai77
fixed some capitalisations and added regression performance checks to…
4be57a2 
… i.e. comparing time taken for different runs
@haelai77
fixed typos
fd70864
@haelai77
added shell property as bash
7ce1245
@haelai77
moved equalities inside brackets
ff75dfc
@haelai77
testing benchmark regression
4841048
@haelai77
changing cache step id
0f3b97e
dANW34V3R
dANW34V3R previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@dANW34V3R dANW34V3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is soo much better. Nice work. And worth saying thanks to @haelai77 for doing the bulk of the work

JosephMoore25
JosephMoore25 requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@JosephMoore25 JosephMoore25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, really nice to have this sorted so elegantly. A couple comments on the clarity and conciseness of some of the code, but these may be agreed to not be necessary. Will be glad to see this go through soon!

.github/workflows/LINUX_BUILD_TEST.yml Show resolved Hide resolved
.github/workflows/LINUX_BUILD_TEST.yml Show resolved Hide resolved
.github/workflows/LINUX_BUILD_TEST.yml Show resolved Hide resolved
.github/workflows/LINUX_BUILD_TEST.yml Show resolved Hide resolved
@ABenC377 ABenC377 dismissed stale reviews from dANW34V3R and FinnWilkinson via 905e676 October 31, 2024 14:20
JosephMoore25
JosephMoore25 previously approved these changes Oct 31, 2024
View reviewed changes
FinnWilkinson
FinnWilkinson previously approved these changes Oct 31, 2024
View reviewed changes
dANW34V3R
dANW34V3R previously approved these changes Nov 1, 2024
View reviewed changes
jj16791
jj16791 reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@jj16791 jj16791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice Job @ABenC377, a strong basis which can hopefully be moved over to a self hosted runner in the future.

.github/actions/select_setup/action.yml Outdated Show resolved Hide resolved
.github/actions/setup_armclang_debian/action.yml Outdated Show resolved Hide resolved
.github/actions/setup_armclang_redhat/action.yml Outdated Show resolved Hide resolved
.github/actions/setup_armclang_rocky/action.yml Outdated Show resolved Hide resolved
FinnWilkinson
FinnWilkinson previously approved these changes Nov 5, 2024
View reviewed changes
dANW34V3R
dANW34V3R previously approved these changes Nov 6, 2024
View reviewed changes
@ABenC377 ABenC377 dismissed stale reviews from dANW34V3R and FinnWilkinson via fc06a88 November 6, 2024 11:58
@ABenC377 ABenC377 merged commit 84f4c7f into dev Nov 6, 2024
37 checks passed
@ABenC377 ABenC377 deleted the CI_CD branch November 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMoore25 JosephMoore25 JosephMoore25 approved these changes

@FinnWilkinson FinnWilkinson FinnWilkinson approved these changes

@dANW34V3R dANW34V3R dANW34V3R approved these changes

@jj16791 jj16791 Awaiting requested review from jj16791

Assignees

@ABenC377 ABenC377

Labels
tests Testing and CI
Projects
SimEng Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul the Jenkin's test pipeline Add CI coverage for macOS
6 participants
@ABenC377 @FinnWilkinson @dANW34V3R @jj16791 @JosephMoore25 @haelai77