Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making GCC7 work on ubuntu 20 #442

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Making GCC7 work on ubuntu 20 #442

merged 5 commits into from
Dec 16, 2024

Conversation

ABenC377
Copy link
Contributor

@ABenC377 ABenC377 commented Dec 5, 2024

Removing ubuntu18 support from testing pipeline due to Github actions no longer supporting the required version of GLIBC

@ABenC377 ABenC377 self-assigned this Dec 5, 2024
@ABenC377 ABenC377 added bug Something isn't working tests Testing and CI labels Dec 6, 2024
dANW34V3R
dANW34V3R previously approved these changes Dec 6, 2024
FinnWilkinson
FinnWilkinson previously approved these changes Dec 9, 2024
JosephMoore25
JosephMoore25 previously approved these changes Dec 9, 2024
dANW34V3R
dANW34V3R previously approved these changes Dec 12, 2024
FinnWilkinson
FinnWilkinson previously approved these changes Dec 12, 2024
@ABenC377 ABenC377 dismissed stale reviews from FinnWilkinson and dANW34V3R via ad3d615 December 13, 2024 11:42
Copy link
Contributor

@JosephMoore25 JosephMoore25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad you found a fix! Perhaps rename the PR to more accurately represent the change for the sake of git history?

@ABenC377 ABenC377 changed the title Removing ubuntu18/gcc7 combo Making GCC7 work on ubuntu 20 Dec 14, 2024
@ABenC377 ABenC377 requested a review from dANW34V3R December 16, 2024 10:54
@ABenC377 ABenC377 merged commit f01b5d6 into dev Dec 16, 2024
37 checks passed
@ABenC377 ABenC377 deleted the actions_fix branch December 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Testing and CI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants