-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making GCC7 work on ubuntu 20 #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABenC377
requested review from
JosephMoore25,
dANW34V3R,
FinnWilkinson and
jj16791
and removed request for
JosephMoore25 and
FinnWilkinson
December 6, 2024 13:14
dANW34V3R
previously approved these changes
Dec 6, 2024
FinnWilkinson
previously approved these changes
Dec 9, 2024
JosephMoore25
previously approved these changes
Dec 9, 2024
ABenC377
dismissed stale reviews from JosephMoore25, FinnWilkinson, and dANW34V3R
via
December 12, 2024 10:39
dbc091e
dANW34V3R
reviewed
Dec 12, 2024
dANW34V3R
previously approved these changes
Dec 12, 2024
FinnWilkinson
previously approved these changes
Dec 12, 2024
ABenC377
dismissed stale reviews from FinnWilkinson and dANW34V3R
via
December 13, 2024 11:42
ad3d615
JosephMoore25
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, glad you found a fix! Perhaps rename the PR to more accurately represent the change for the sake of git history?
FinnWilkinson
approved these changes
Dec 13, 2024
jj16791
approved these changes
Dec 14, 2024
dANW34V3R
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing ubuntu18 support from testing pipeline due to Github actions no longer supporting the required version of GLIBC