fix(Galery): fix autoPlay when dragging slides #7877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7877 +/- ##
==========================================
- Coverage 95.37% 95.36% -0.01%
==========================================
Files 378 378
Lines 11160 11165 +5
Branches 3711 3712 +1
==========================================
+ Hits 10644 10648 +4
- Misses 516 517 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit c81ef9c |
andrey-medvedev-vk
previously approved these changes
Nov 2, 2024
inomdzhon
reviewed
Nov 5, 2024
EldarMuhamethanov
added
the
patch
andrey-medvedev-vk
previously approved these changes
Nov 5, 2024
inomdzhon
reviewed
Nov 5, 2024
BlackySoul
reviewed
Nov 6, 2024
inomdzhon
approved these changes
Nov 6, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7835/autoplay-slides-gallery
branch
❌ PatchНе удалось автоматически применить исправление на ветке 7.0-stable.
Чтобы изменение попало в ветку 7.0-stable, выполните следующие действия:
git stash # опционально
git fetch origin 7.0-stable
git checkout -b patch/pr7877 origin/7.0-stable
git cherry-pick --no-commit 3661e98a0a3df99584a8d90623e240c44cde5427
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr7877
gh pr create --base 7.0-stable --title "patch: pr7877" --body "- patch #7877" |
vkcom-publisher
pushed a commit
that referenced
this pull request
Nov 6, 2024
* fix(Galery): fix autoPlay when dragging slides * fix(HorizontalScroll): remove unused useEffect * fix(Gallery): rm useImperativeHandler and return controls from hook * fix(Gallery): rm import * fix(useAutoPlay): use useCallback * fix(useAutoPlay): rm import
EldarMuhamethanov
added a commit
that referenced
this pull request
Nov 6, 2024
* fix(Galery): fix autoPlay when dragging slides * fix(HorizontalScroll): remove unused useEffect * fix(Gallery): rm useImperativeHandler and return controls from hook * fix(Gallery): rm import * fix(useAutoPlay): use useCallback * fix(useAutoPlay): rm import (cherry picked from commit 3661e98)
Merged
EldarMuhamethanov
added a commit
that referenced
this pull request
Nov 6, 2024
* fix(Galery): fix autoPlay when dragging slides * fix(HorizontalScroll): remove unused useEffect * fix(Gallery): rm useImperativeHandler and return controls from hook * fix(Gallery): rm import * fix(useAutoPlay): use useCallback * fix(useAutoPlay): rm import (cherry picked from commit 3661e98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас при включеном autoPlay в компоненте Gallery при попытке потянуть слайд, таймер не сбрасывается, из-за чего происходит переход прямо во время drag
Изменения
Сделал рефакторинг хука
useAutoPlay, добавил возможность сделатьpauseиresumeво время работы с GalleryRelease notes
Исправления
dragпроисходит остановка автопереключения слайдов