Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling symbol resolution for some modules #112

Closed
wants to merge 1 commit into from
Closed

Allow disabling symbol resolution for some modules #112

wants to merge 1 commit into from

Conversation

UnrealKaraulov
Copy link

@UnrealKaraulov
Copy link
Author

@CyberShadow need Your help :)

@CyberShadow
Copy link
Member

I can't test it but the diff looks good. Actually I would suggest to simplify it a little. The module list can just be a hidden option (and stored together with all options), for example as a string separated by |, then there's no need to do file I/O.

@CyberShadow
Copy link
Member

need Your help :)

What do you need help with, does it not work for you?

@UnrealKaraulov
Copy link
Author

@CyberShadow Can it be merged, or do I need to make changes?

@CyberShadow
Copy link
Member

I can merge this as is. But just so we understand each other...

  1. Do you agree with the suggestion above (regardless of who implements it)? If not, maybe I misunderstood something?
  2. Do you want to stop working on this and get it merged as is?

@UnrealKaraulov
Copy link
Author

@CyberShadow as need for project owner:)

but I don't know how to add command line parser, it works for me as is, but you can improve it if needed

@CyberShadow
Copy link
Member

I don't think we need a command line parser. My idea was to replace the file reading with wxString::split.

Also it would be nice to have a menu option (e.g. in the right-click menu) to toggle symbol resolution in the selected function's module, that would allow removing all other GUI for the option (so no changes in the options dialog window). Does that make sense to you?

@UnrealKaraulov
Copy link
Author

UnrealKaraulov commented Feb 8, 2023

I don't think we need a command line parser. My idea was to replace the file reading with wxString::split.

Also it would be nice to have a menu option (e.g. in the right-click menu) to toggle symbol resolution in the selected function's module, that would allow removing all other GUI for the option (so no changes in the options dialog window). Does that make sense to you?

First I tried to add 'ignore module' to context menu, but it not works, I think because is not reloaded ? (I just don't know how to works code in this tool)

In this PR i just added read file beforce profile started.

Yes I think it can be easy replaced to string::split without problems but I removed project from HDD ) You can do it without me...)

I'm leaving this PR!
I'm leaving this PR!

@CyberShadow
Copy link
Member

OK, thanks! I will have a closer look at this when I'm home and have access to my Windows development VM.

@UnrealKaraulov
Copy link
Author

@CyberShadow ........

@CyberShadow
Copy link
Member

I forgor 💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants