Feature/107 fix bugs security issues and maintenance issues in mccl and mcpp #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2023 15:08
…l to the one in MCCL Added InternalsVisibleTo for the MCPP application because it is needed for the stand-alone MCPP
hayakawa16
reviewed
Oct 1, 2023
There was a problem hiding this comment.
Why is suggested update to local variable CPUCount name cpuCount and not cPuCount? I found an example of local variable in pMCDatabase.cs of pMCDatabase and suggested name is pMcDatabase.
There was a problem hiding this comment.
CPU is an acronym like API and are considered words like Count and Database, putting an uppercase P in the middle is not right, I guess it made that suggestion incorrectly, it should be pmcDatabase in camel case and PmcDatabase in Pascal case.
There was a problem hiding this comment.
I see. Thanks for your response.
hayakawa16
reviewed
Oct 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
lmalenfant
deleted the
feature/107-fix-bugs-security-issues-and-maintenance-issues-in-mccl-and-mcpp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.