Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer config access in legend #919

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Add layer config access in legend #919

merged 12 commits into from
Nov 9, 2023

Conversation

hav142
Copy link
Collaborator

@hav142 hav142 commented Jul 14, 2023

This PR is still drafted to fixes issue #793

How to test the feature:

  • activate any layer
  • check the icons on the legend

@wadhwamatic
Copy link
Member

wadhwamatic commented Jul 14, 2023

Nice work on this @hav142!

Can we have the legend box and the opacity / download interfaces the same width?
Screenshot 2023-07-14 at 13 35 56

Screenshot 2023-07-14 at 13 35 50

Some minor inputs from me which are just for consideration:

  1. I think the icons can now be left aligned since they no longer are in-line with the layer name. What do you think?
  2. A little more spacing between the legend detail text and the icons would be good to give some more room
  3. I think we can space out the icons a bit too

@hav142
Copy link
Collaborator Author

hav142 commented Jul 20, 2023

@wadhwamatic Thanks for the suggestions. Is this good enough?

image

@wadhwamatic
Copy link
Member

@hav142 - yes, that looks good. as you move forward with this, please have a look at #920 to make sure that the CSV download feature for exposure analysis works with your revised UI

@ericboucher
Copy link
Collaborator

@hav142 can you have a look at the linting issues? The demo endpoint will only get deployed if all the tests and linters are passing. Thanks!

Copy link

github-actions bot commented Nov 7, 2023

Build succeeded and deployed at https://prism-919.surge.sh
(hash f3eb9ad deployed at 2023-11-09T11:53:20)

@echaidemenos echaidemenos marked this pull request as ready for review November 7, 2023 12:45
@@ -2690,14 +2690,28 @@
dependencies:
"@types/react" "*"

"@types/react@*", "@types/react@^16.9.0":
"@types/react@*":
version "16.9.23"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the types too?

@wadhwamatic
Copy link
Member

wadhwamatic commented Nov 8, 2023

Thanks for picking this up again @echaidemenos. This works well except when I try to download a raster (WMS) layer. The download link works in the layer navigation, but not in the legend. See the error below from the legend download button:

Screenshot 2023-11-08 at 13 33 35

@ericboucher - this sounds related to the issue we saw earlier today.

Copy link
Member

@wadhwamatic wadhwamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @echaidemenos !

@ericboucher ericboucher changed the title Layer functionality access on legend Add layer config access in legend Nov 9, 2023
@ericboucher ericboucher merged commit b800ac7 into master Nov 9, 2023
6 checks passed
@ericboucher ericboucher deleted the legend-icons branch November 9, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants