-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer config access in legend #919
Conversation
Nice work on this @hav142! Can we have the legend box and the opacity / download interfaces the same width? Some minor inputs from me which are just for consideration:
|
@wadhwamatic Thanks for the suggestions. Is this good enough? |
@hav142 can you have a look at the linting issues? The demo endpoint will only get deployed if all the tests and linters are passing. Thanks! |
Build succeeded and deployed at https://prism-919.surge.sh |
@@ -2690,14 +2690,28 @@ | |||
dependencies: | |||
"@types/react" "*" | |||
|
|||
"@types/react@*", "@types/react@^16.9.0": | |||
"@types/react@*": | |||
version "16.9.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the types too?
Thanks for picking this up again @echaidemenos. This works well except when I try to download a raster (WMS) layer. The download link works in the layer navigation, but not in the legend. See the error below from the legend download button: @ericboucher - this sounds related to the issue we saw earlier today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @echaidemenos !
This PR is still drafted to fixes issue #793
How to test the feature: