Exposure Analysis Download CSV access from anywhere #920
Conversation
|
Build succeeded and deployed at https://prism-920.surge.sh |
|
We can actually access now the
|
|
Nice work on this @HarryMytilinaios! This is very much needed. We need to harmonize this with the UI that @hafidz142 has worked in PR #919. I mentioned the same to @ericboucher. Thanks for syncing up on this with them next week |
…m-multiple-places
|
@HarryMytilinaios - I sync'd with @ericboucher about this earlier. Let's go ahead and merge this and we'll have @hafidz142 update his PR afterwards Pending @ericboucher's approval! |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@HarryMytilinaios you can click here to see the review status or cancel the code review job - or - cancel by adding [!pr] to the title of the pull request.
There was a problem hiding this comment.
Overall, this set of changes is looking good, nice work! I've left one small recommendation that could optionally be applied before merging. No major issues stood out.
Reviewed with ❤️ by PullRequest
| const analysisDefinition = useSelector(getCurrentDefinition); | ||
|
|
||
| const exposureAnalysisTableData = getExposureAnalysisTableData( | ||
| analysisData?.tableData as TableRow[], |
There was a problem hiding this comment.
This optional chain implies that this expression might return undefined, but I see it's being cast as an always-truthy TableRow[]. Could a fallback empty array make this line less error-prone?
(analysisData?.tableData || []) as TableRow[],A similar suggestion applies to the related changes in AnalysisDownloadButton.tsx in this PR.
🔹 Reduce Future Bugs (Nice to have)
There was a problem hiding this comment.
No merge blocking issues found. Changes are in line with what is stated in the description of the PR. Thanks for the pull request.
Reviewed with ❤️ by PullRequest
ericboucher
changed the title
ericboucher
deleted the
feature/download-csv-exposure-analysis-from-multiple-places
branch
This PR adds the
Download CSVfunctionality for theExposure Analysisboth in theLayer Accordioncomponent and in theLegendcomponent, giving us access to download it from both places as well as the theExposureAnalysisActionsbelow the table. The sorting functionality is also ported to all places.