-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gmsh extension3 #34
Gmsh extension3 #34
Conversation
Added rudimentary mixed grid functions and the possibility to load an incomplete grid (no boundary) from gmsh
Computes the boundary faces of an incomplete simplexgrid and adds them to it
seal.jl is now included
mixedgrid functions for the gmsh extension are defined
rename a function in the gmsh extension
"testmesh.gmsh" is an incomplete grid and "mixedgrid_2d.msh" is a grid containing triangles and rectangles. We added functionalities for both types of grids and they can be tested with those grids.
added tests for mixed and incomplete tests
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 70.83% 71.92% +1.09%
==========================================
Files 25 26 +1
Lines 3761 4082 +321
==========================================
+ Hits 2664 2936 +272
- Misses 1097 1146 +49 ☔ View full report in Codecov by Sentry. |
@cmerdon - could you try this PR ? IMHO it is ok. |
good, it works for me. However, simplexgrid_from_gmsh seems to generate an ExtendalbeGrids{Float64, Int64} always, there seems to be no way to use Int32. Maybe we want to have that possibility? |
Hm @jotaraz, how does gmsh store integers ? Always as 64bit ? |
now you can decide which types (indices and coordinates) you want for gmsh -> ExtendableGrids
add tests with different types (of indices & coordinates) for gmsh Y ExtendableGrids
@j-fu @chmerdon As far as I know, Gmsh (or at least Gmsh.jl) stores node indices etc. as UInt64 and the coordinates as Float64. Since the last updates, there is the possibility to construct a grid from a gmsh file (or module) with any desired types for Ti, Tc. The conversion in the other direction (ExtendableGrid -> Gmsh) seems to work already, independently of the type of the ExtendableGrid. |
I would like to make
public API for all the gmsh stuff. As for the tests: Gmsh creates different grids on windows... |
Most important: Added functions for incomplete grids. (read from gmsh and seal)
Secondly: Added rudimentary functions for mixed grids