Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmsh extension3 #34

Merged
merged 17 commits into from
Nov 22, 2023
Merged

Gmsh extension3 #34

merged 17 commits into from
Nov 22, 2023

Conversation

jotaraz
Copy link
Collaborator

@jotaraz jotaraz commented Aug 19, 2023

Most important: Added functions for incomplete grids. (read from gmsh and seal)
Secondly: Added rudimentary functions for mixed grids

Added rudimentary mixed grid functions and the possibility to load an incomplete grid (no boundary) from gmsh
Computes the boundary faces of an incomplete simplexgrid and adds them to it
seal.jl is now included
mixedgrid functions for the gmsh extension are defined
rename a function in the gmsh extension
"testmesh.gmsh" is an incomplete grid and "mixedgrid_2d.msh" is a grid containing triangles and rectangles.
We added functionalities for both types of grids and they can be tested with those grids.
added tests for mixed and incomplete tests
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (baf258e) 70.83% compared to head (ad712b8) 71.92%.

Files Patch % Lines
src/extendablegrid.jl 62.90% 46 Missing ⚠️
ext/ExtendableGridsGmshExt.jl 89.77% 23 Missing ⚠️
src/io.jl 90.55% 12 Missing ⚠️
src/seal.jl 91.86% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   70.83%   71.92%   +1.09%     
==========================================
  Files          25       26       +1     
  Lines        3761     4082     +321     
==========================================
+ Hits         2664     2936     +272     
- Misses       1097     1146      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu
Copy link
Member

j-fu commented Aug 22, 2023

@cmerdon - could you try this PR ? IMHO it is ok.

@chmerdon
Copy link
Member

good, it works for me. However, simplexgrid_from_gmsh seems to generate an ExtendalbeGrids{Float64, Int64} always, there seems to be no way to use Int32. Maybe we want to have that possibility?

@j-fu
Copy link
Member

j-fu commented Aug 22, 2023

Hm @jotaraz, how does gmsh store integers ? Always as 64bit ?
May be we could add a kwarg indextype which by default would be what gmsh has.

now you can decide which types (indices and coordinates) you want for gmsh -> ExtendableGrids
add tests with different types (of indices & coordinates) for gmsh Y ExtendableGrids
@jotaraz
Copy link
Collaborator Author

jotaraz commented Aug 28, 2023

@j-fu @chmerdon As far as I know, Gmsh (or at least Gmsh.jl) stores node indices etc. as UInt64 and the coordinates as Float64.

Since the last updates, there is the possibility to construct a grid from a gmsh file (or module) with any desired types for Ti, Tc. The conversion in the other direction (ExtendableGrid -> Gmsh) seems to work already, independently of the type of the ExtendableGrid.

@j-fu
Copy link
Member

j-fu commented Nov 16, 2023

I would like to make

ExtendableGrids.simplexgrid_from_gmsh
ExtendableGrids.simplexgrid_to_gmsh
ExtendableGrids.mixedgrid_from_gmsh
ExtendableGrids.mixedgrid_to_gmsh

public API for all the gmsh stuff.
Maybe mixed and simplex could be merged.

As for the tests: Gmsh creates different grids on windows...

@j-fu j-fu merged commit db7713f into master Nov 22, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants