Update No Duplicate Rule to signify that it is Shared Id that can't appear in more than one job, not the reports. #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating No Duplicate rule to say that the Shared Id can't be in more than one batch even though the reports can be shared. With contribution Filtering, the filtering Id is included in the Shared ID generation. So, the reports can feature in different batches, but the Shared ID representing the disjoint data in them, can't be.
apasel422
requested changes
Dec 12, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
requested review from
linnan-github
and removed request for
apasel422
linnan-github
approved these changes
Dec 18, 2024
arpanah
reviewed
Dec 18, 2024
| @@ -243,7 +244,7 @@ single aggregation batch (as duplicates) or in multiple batches. Because | |||
| of this, the aggregation service enforces a "no duplicates" rule: | |||
|
|
|||
| * No aggregatable report can appear more than once within a batch. | |||
| * No aggregatable report can appear in more than one batch or contribute | |||
| * No Shared ID can appear in more than one batch or contribute | |||
There was a problem hiding this comment.
What does 'Or contribute' mean in this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With contribution filtering implementation done, the filtering ID is included in the Shared ID generation. Since the data is disjoint between filtering IDs, a report can appear in multiple batches as long as their Shared IDs are not the same across them. This warrants an update to the No Duplicate rule because it is not the reports that shouldn't be duplicated, but the underlying data represented by Shared ID, that shouldn't be.