Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update No Duplicate Rule to signify that it is Shared Id that can't appear in more than one job, not the reports. #1478

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update No Duplicate Rule to signify that it is Shared Id that can't appear in more than one job, not the reports. #1478

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5afd39f
Update AGGREGATION_SERVICE_TEE.md
preethiraghavan1 Dec 11, 2024
94ea561
Update AGGREGATION_SERVICE_TEE.md
preethiraghavan1 Dec 11, 2024
e7723d7
Merge branch 'WICG:main' into main
preethiraghavan1 Dec 11, 2024
0b59d3a
Update AGGREGATION_SERVICE_TEE.md
preethiraghavan1 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions AGGREGATION_SERVICE_TEE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ throughout this proposal.
* _Coordinator:_ an entity responsible for key management and aggregatable report
accounting. The coordinator maintains a list of hashes of approved aggregation
service configurations and configures access to decryption keys.
* _Shared ID:_ A unique identifier assigned to a group of reports in combination with [filtering IDs](https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/flexible_filtering.md#proposal-filtering-id-in-the-encrypted-payload) to prevent overlap between batches of reports. This eliminates the need to track individual reports and allows for efficient privacy budget management at the group level.

## Aggregation workflow

Expand Down Expand Up @@ -243,7 +244,7 @@ single aggregation batch (as duplicates) or in multiple batches. Because
of this, the aggregation service enforces a "no duplicates" rule:

* No aggregatable report can appear more than once within a batch.
* No aggregatable report can appear in more than one batch or contribute
* No Shared ID can appear in more than one batch or contribute
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 'Or contribute' mean in this context?

to more than one summary report.

The no-duplicates rule is enforced during aggregation. If duplicates are
Expand All @@ -254,8 +255,8 @@ found, these batches may be rejected or duplicates may be filtered out.
It is not technically practical to keep track of every single aggregatable
report submitted for aggregation to check for batch disjointness, that is,
that batches are not overlapping. Instead, each aggregatable report will
be assigned a shared ID. This ID is generated from the combined data points: API version, reporting origin, destination site, source registration time and scheduled report time.
These data points come from the report's [shared_info](https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md#aggregatable-reports) field.
be assigned a shared ID. This ID is generated from the combined data points: API version, reporting origin, destination site, source registration time, scheduled report time, and filtering ID.
These data points come from the report's [shared_info](https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md#aggregatable-reports) field and from the job parameter in the request.

The aggregation service will enforce that all aggregatable reports with
the same ID must be included in the same batch. Conversely, if more than
Expand Down