BoxControl: Fix aria-valuetext
value
#68362
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #67688
What?
This PR applies the appropriate label to
aria-valuetext
when theBoxControl
component has presets, allowing screen readers to properly announce the preset values.Why?
The
aria-valuenow
attribute is used in a range widget to communicate the current value, and thearia-valuetext
attribute is used to provide more human-readable text.The current implementation references the
label
field, which is always an empty string, soaria-valuetext
is effectively non-functional.How?
From my understanding, the reason the
label
field is empty is because we do not want to display a visual mark label, so thelabel
field should be left empty. Instead, apply the tooltip text toaria-valuetext
as well, so that the text read by screen readers matches the visual tooltip text.This should match the implementation of the
SpacingSizesControl
component.Testing Instructions
npm run storybook:dev
aria-valuetext
attribute via your browser developer tools.Screenshots or screencast
3ade381fd967ce06444a3114e4b32a39.mp4