Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoxControl: Fix aria-valuetext value #68362

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

BoxControl: Fix aria-valuetext value #68362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffe3953
BoxControl: Fix `aria-valuetext` value
t-hamano Dec 28, 2024
32fd9f7
Update changelog
t-hamano Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
### Bug Fixes

- `BoxControl`: Better respect for the `min` prop in the Range Slider ([#67819](https://github.com/WordPress/gutenberg/pull/67819)).
- `BoxControl`: Fix aria-valuetext value ([#68362](https://github.com/WordPress/gutenberg/pull/68362)).

### Experimental

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/box-control/input-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export default function BoxInputControl( {
}
aria-valuetext={
marks[ presetIndex !== undefined ? presetIndex + 1 : 0 ]
.label
.tooltip
}
renderTooltipContent={ ( index ) =>
marks[ ! index ? 0 : index ].tooltip
Expand Down
Loading