Fix Ansible lint in galaxy.yml and meta #17
Conversation
- version 0.0.1 is not allowed, use 1.0.0-beta until officially released - role name is obsolete after migration into collection - provide minimal changelog - platform is EL for CentOS and RedHat - use ansible 2.12 as minimum version
| @@ -10,7 +10,7 @@ namespace: worteks | |||
| name: lemonldap | |||
|
|
|||
| # The version of the collection. Must be compatible with semantic versioning | |||
| version: 0.0.1 | |||
| version: 1.0.0-beta | |||
There was a problem hiding this comment.
0.0.1 is a correct from a semantic versioning point of view, I'm not sure this is necessary.
| @@ -5,14 +5,10 @@ galaxy_info: | |||
| company: Worteks | |||
| issue_tracker_url: https://github.com/worteks/ansible-lemonldapng/issues | |||
| license: MIT | |||
| min_ansible_version: 2.4 | |||
| min_ansible_version: "2.12" | |||
There was a problem hiding this comment.
Could you please explain why 2.4 is not high enough ?
There was a problem hiding this comment.
i think 2.4 is EOL since a long time, we should probably set the min_ansible_version to ansible-core 2.16
|
Ansible-lint complains about 2.4 being outdated, so I tried more recent versions and 2.12 was accepted. The minimum version should be as low as possible. Otherwise, users of conservative / LTS Linux Distributions would be excluded.
Example, the current Debian stable 12 Bookworm provides 2.14.
2.12 seems to be a good compromise to me.
|
Conservative/stable distributions is what I had in mind. EL7 (still supported for a couple days) has 2.9, Debian 10 has 2.7, Debian 11 has 2.10, Ubuntu 20.04 has 2.9 and Ubuntu 22 has 2.10. |
i don't know if it's worth taking care of compatibility with so old version. I guess people who will install LemonLDAP, won't do it on (almost) dead version and we suppor them it will be real pain to maintain / test compatibility with those system. |
This PR will fix the remaining ansible-lint complains.
Summary:
Tested with: ansible-lint 6.13.1 using ansible 2.14.3