Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible lint in galaxy.yml and meta #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
releases:
1.0.0-beta:
release_date: '2024-06-01'
changes:
release_summary: Preparation for the first official release
major_changes:
- Migration from role to collection
4 changes: 3 additions & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace: worteks
name: lemonldap

# The version of the collection. Must be compatible with semantic versioning
version: 0.0.1
version: 1.0.0-beta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0.1 is a correct from a semantic versioning point of view, I'm not sure this is necessary.


# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
readme: README.md
Expand Down Expand Up @@ -40,6 +40,8 @@ license_file: ''
# A list of tags you want to associate with the collection for indexing/searching. A tag name has the same character
# requirements as 'namespace' and 'name'
tags:
- linux
- security
- authentication
- SSO
- SAML
Expand Down
2 changes: 2 additions & 0 deletions meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
requires_ansible: ">=2.12.0"
16 changes: 6 additions & 10 deletions roles/install/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ galaxy_info:
company: Worteks
issue_tracker_url: https://github.com/worteks/ansible-lemonldapng/issues
license: MIT
min_ansible_version: 2.4
min_ansible_version: "2.12"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain why 2.4 is not high enough ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think 2.4 is EOL since a long time, we should probably set the min_ansible_version to ansible-core 2.16

github_branch: master
role_name: workteks.lemonldap
platforms:
- name: CentOS
versions:
- all
- name: RedHat
- name: EL
versions:
- all
- name: Debian
Expand All @@ -23,8 +19,8 @@ galaxy_info:
- all
galaxy_tags:
- authentication
- SSO
- SAML
- LemonLDAP-NG
- Web
- sso
- saml
- lemonldapng
- web
dependencies: []
Loading