Fix dali binding #102
Merged
Fix dali binding #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
reviewed
Apr 20, 2024
| @@ -151,3 +152,5 @@ def test_submit_job_arguments(): | |||
| assert ( | |||
| len(missing_params) == 0 | |||
| ), f"Missing parameters in submit_job: {', '.join(missing_params)}" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
No extra final line please.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic validators are called according to the sequence of the input arguments. In the old code "bind" was behind "partition", so the binding reset for dali
utilix/utilix/batchq.py
Line 211 in 4bf9682
doesn't actually work, as the bind will be overwritten in the bind validator.
This PR fixes this problem by moving "bind" in front of "partition"