Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dali binding #102

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix dali binding #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64bcbe2
add partition info in test
yuema137 Apr 19, 2024
82a36ce
put bind in front of partition
yuema137 Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/test_batchq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
def valid_job_submission() -> JobSubmission:
return JobSubmission(
jobstring="Hello World",
partition="xenon1t",
qos="xenon1t",
hours=10,
container="xenonnt-development.simg",
Expand Down Expand Up @@ -151,3 +152,5 @@ def test_submit_job_arguments():
assert (
len(missing_params) == 0
), f"Missing parameters in submit_job: {', '.join(missing_params)}"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extra final line please.

8 changes: 4 additions & 4 deletions utilix/batchq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ class JobSubmission(BaseModel):
False, description="Exclude the loosely coupled nodes"
)
log: str = Field("job.log", description="Where to store the log file of the job")
bind: List[str] = Field(
default_factory=lambda: DEFAULT_BIND,
description="Paths to add to the container. Immutable when specifying dali as partition",
)
partition: Literal[
"dali", "lgrandi", "xenon1t", "broadwl", "kicp", "caslake", "build"
] = Field("xenon1t", description="Partition to submit the job to")
Expand All @@ -137,10 +141,6 @@ class JobSubmission(BaseModel):
container: str = Field(
"xenonnt-development.simg", description="Name of the container to activate"
)
bind: List[str] = Field(
default_factory=lambda: DEFAULT_BIND,
description="Paths to add to the container. Immutable when specifying dali as partition",
)
cpus_per_task: int = Field(1, description="CPUs requested for job")
hours: Optional[float] = Field(None, description="Max hours of a job")
node: Optional[str] = Field(
Expand Down
Loading