Auto check binding #110
Merged
Auto check binding #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsriya
approved these changes
May 31, 2024
dachengx
reviewed
Jun 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this slack thread, the instability of mounting affects the performance of
env_starterandbatchq.To avoid manually modifying the codes based on the variant status of servers, a better practice is to put all possible bindings and image locations in those two modules and do an automatic check to avoid problematic ones. By doing that, we can guarantee that users will get all of the possible resources without touching the inner side of the tools. The implementation of image location checking was done in #108, and here, we also added a similar function to the binding.
The unit tests are also updated accordingly. I have run the tests on midway2, midway3 and dali and on all servers they are working well.